Interesting discussion on kids in sports. Lots of good points both ways. I'm a parent of 3 boys between age 5 and 10 and I help coach multiple teams in both hockey and baseball. I LOVE coaching kids (not just my kids). It's a passion for me and I clearly do get a lot out of youth sports myself. That said, I don't think there's a right answer as each situation is different. I have a couple of points to add:
1. I think sports provides a great opportunity for kids to learn about dedication, team work, responsibility, hard work, resiliency, etc. Unfortunately, in my experience, kids who play at the local league level rarely gain these through sport. There are little to no expectations or dedication. Lots of kids who don't really want to be there and even fewer who want to work hard. It never really feels like you're on a 'team'. If your kids like a sport and you can give then opportunities to improve and give them a better chance of making a rep/travel teams - I think it's worthwhile.
2. I think there are times when a little parent push is beneficial. I have 2 boys who love hockey and would hit the ice multiple times a day if they could. My 3rd often gives us a hard time about going to practices (especially during COVID as he misses games). If truly given the choice, he'd probably just sit on the couch and do nothing. But, when he puts up a fuss, we do have to push back a bit. Nearly 99% of the time, as soon as he gets out there, he's smiling and having a great time and leaves the arena happy. To be honest, I was a goalie as a kid and I hated practice and often gave my parents a hard time. They never let me quit and while I don't really like hockey, I have great memories of it, made life long friends and learned a lot of lessons that transcend the sport. Obviously there are plenty of occasions when parents unnecessarily/negatively push their kids into sports, but IMO, it's not always wrong.
I also agree with lots of the other good points made. The money angle and accessibility is a challenging, but real issue. Push too much or too early and you risk them losing the passion/interesting (push the right amount and they might develop great habits that are utilized throughout their youth). Have a kid who clearly loves it a young age, encourage them. There is no one answer fits all response to this discussion.