The way I see it, Smoak and Carter are both feast/famine hitters except that Carter is an established feast/famine hitter while Smoak is just an aspiring one. Offensively, that's a no brainer upgrade given that you're getting a more successful version of the same thing. The only caveat I can think of is the gap in defensive ability. I'm not sure how much that negates the offensive upgrade.